thopre accepted this revision. thopre added a comment. LGTM. Sorry for the late review.
================ Comment at: llvm/test/FileCheck/comment/after-words.txt:1 +# Comment prefixes are not recognized at ends of words. + ---------------- jdenny wrote: > jdenny wrote: > > thopre wrote: > > > How about characters that cannot be part of an identifier? E.g. would > > > "@COM:" be interpreted as a comment? Should we only accept comment prefix > > > if it's a space or beginning of line before? > > Yes, this patch interprets `@COM:` as a comment directive. > > > > My justification is that, to keep things simple for the FileCheck user and > > implementation, I tried to keep parsing of comment directives and check > > directives as similar as possible. One intentional difference is that > > comment directives are ignored if they have check suffixes, such as `-NOT`. > `git grep '@RUN'` shows that `@` without a following space might be a comment > style we should support. Here's an example match: > > ``` > llvm/test/MC/ARM/ldr-pseudo-cond-darwin.s:@RUN: llvm-mc -triple > armv7-base-apple-darwin %s | FileCheck --check-prefix=CHECK-ARM > --check-prefix=CHECK %s > ``` You're right, I forgot CHECK directives have the same problem. This should be fixed by the patch that was proposed to force a comment mark or beginning of line for a prefix to be recognized as a directive. Patch LGTM then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
