rnk added inline comments.

================
Comment at: clang/lib/Lex/PPDirectives.cpp:2118
+    // given drive letter case as correct for the purpose of this warning.
+    SmallString<128> FixedDriveRealPath;
+    if (llvm::sys::path::is_absolute(Name) &&
----------------
It seems like trySimplifyPath could check if it is checking the case of the 
first component on Windows, and that would hide the complexity from the main 
Preprocessor::HandleHeaderIncludeOrImport implementation. It also saves a 
string copy for every include.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79531/new/

https://reviews.llvm.org/D79531



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to