hliao added a comment. In D79344#2018561 <https://reviews.llvm.org/D79344#2018561>, @tra wrote:
> This has a good chance of breaking existing code. It would be great to add an > escape hatch option to revert to the old behavior if we run into problems. > The change is relatively simple, so reverting it in case something goes wrong > should work, too. Up to you. Why? for the cases addressed in this patch, if there is existing code, it won't be compiled to generate module file due to the missing symbol. Anything missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79344/new/ https://reviews.llvm.org/D79344 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
