mibintc marked an inline comment as done.
mibintc added inline comments.

================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:870
+def err_pragma_fenv_requires_precise : Error<
+  "'#pragma STDC FENV_ACCESS ON' is illegal when precise is disabled">;
 def warn_cxx_ms_struct :
----------------
erichkeane wrote:
> The last 4 can be done via selects as well!  Save a couple more spaces before 
> we have to up the diagnostic id size :) 
> 
> The last 4 can be done via selects as well
Combining these 4 into 1 diagnostic is doable but it's ugly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72841/new/

https://reviews.llvm.org/D72841



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to