aykevl added a comment.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

A thought: should the AVR family be included in the target triple? Like 
`avr5-unknown-unknown` (similar to `armv6m-none-eabi`, `armv7m-none-eabi`, etc).
The different variations do sometimes change the architecture in incompatible 
ways, such as with the call instruction 
<http://ww1.microchip.com/downloads/en/devicedoc/atmel-0856-avr-instruction-set-manual.pdf#page=63>
 which pushes a return address of two or three bytes depending on the 
architecture variant (and thus makes it impossible to pass parameters on the 
stack reliably).

I don't think this should block this patch (which I hope will get updated so it 
can land soon), but it may be something to consider.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77221/new/

https://reviews.llvm.org/D77221



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D77221: [AVR] Rework M... Ayke via Phabricator via cfe-commits

Reply via email to