NoQ added a comment.

Yay unit tests! Let's squash those mutually cancelling bugs.



================
Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:22-32
+  struct TestContext {
+    StoreManager &SManager;
+    SValBuilder &Builder;
+    MemRegionManager &MRManager;
+    ASTContext &ASTContext;
+
+    /* implicit */ TestContext(ExprEngine &Engine)
----------------
Why was this necessary? All these variables seem to be already available in the 
surrounding scope as fields in `ExprEngineConsumer`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78990/new/

https://reviews.llvm.org/D78990



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to