MaskRay added inline comments.
================ Comment at: clang/docs/UsersManual.rst:786 + + $ clang -fproc-stat-report=- foo.c + clang-11: output=/tmp/foo-123456.o, total=84000, user=76000, mem=87496 ---------------- aganea wrote: > Why not just `-fproc-stat-report` in this case? It can save an `Option`.. ================ Comment at: clang/docs/UsersManual.rst:787 + $ clang -fproc-stat-report=- foo.c + clang-11: output=/tmp/foo-123456.o, total=84000, user=76000, mem=87496 + ld: output=a.out, total=8000, user=8000, mem=53548 ---------------- aganea wrote: > I think it is better if the units are specified along (and locale-formatted, > if possible): > ``` > clang-11: output=/tmp/foo-123456.o total=84,000 ms user=76,000 ms > mem=87,496 kb > ``` Sorry, I tend to disagree with the argument for decimal separators and locale differences. They make behaviors divergent and make the output difficult to parse by a script. (Scripts may have to use `LANG=C clang -fproc-stat-report=-` to cancel the locale effect) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
