PaulkaToast added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/llvmlibc/CalleeNamespaceCheck.cpp:52-53 + + diag(FuncDecl->getLocation(), + "currently resolves to: ", clang::DiagnosticIDs::Note); +} ---------------- aaron.ballman wrote: > PaulkaToast wrote: > > aaron.ballman wrote: > > > This diagnostic seems a bit strange -- I would expect some text after the > > > colon. > > I was trying mimic the clang's previous definition diagnostic. e.g. : > > https://godbolt.org/z/V4tKr- > > Although the colon does seem to confusing so I removed it. > Ah, thank you for the explanation. I think I would word it `resolves to this > declaration` (or something along those lines) to be a bit less grammatically > ambiguous. When the diagnostic ends in "to", I assume there's a part of the > diagnostic missing and I wonder "to what?" I agree with this, thanks for the insight (: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78890/new/ https://reviews.llvm.org/D78890 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
