hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/CodeGen/TargetInfo.h:51
- TargetCodeGenInfo(ABIInfo *info = nullptr) : Info(info) {}
- virtual ~TargetCodeGenInfo();
----------------
I'm not sure removing a virtual destructor is a good idea. The use of `delete`
in relation to `TargetCodeGenInfo` (and derived class) pointers would need to
be checked.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79033/new/
https://reviews.llvm.org/D79033
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
