Quuxplusone added inline comments.
================
Comment at: llvm/include/llvm/Support/BinaryStreamRef.h:124
- bool operator==(const RefType &Other) const {
- if (BorrowedImpl != Other.BorrowedImpl)
+ friend bool operator==(const RefType &Self, const RefType &Other) {
+ if (Self.BorrowedImpl != Other.BorrowedImpl)
----------------
Is there a neat rule of thumb for when you were able to preserve the member
`bool Me::operator==(const Me& rhs) const` versus when you were forced to
change it to a hidden friend? It seems like maybe you changed it to a hidden
friend only in cases where `Me` was a base class, is that right?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78938/new/
https://reviews.llvm.org/D78938
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
