NoQ added a comment. In D77229#2005218 <https://reviews.llvm.org/D77229#2005218>, @baloghadamsoftware wrote:
> In D77229#2005042 <https://reviews.llvm.org/D77229#2005042>, @NoQ wrote: > > > > no crashes but 130 of 550 analyzer tests failing. > > > > You most likely need to fill in the reachibility and liveness code with the > > behavior of the new region. I don't seem to see it in your current code but > > their default behavior is clearly incorrect; instead, they should behave > > exactly like the old region used to. > > > Do you mean the `getBinding...()` function of `RegionStore` and the > `isLive...()` functions of `SymbolManager`? Yup, you're right, i should have mentioned basically the whole RegionStore's load/store process instead of just the escape/invalidation process that relies on reachibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
