pcc added inline comments. ================ Comment at: lib/CodeGen/CGDebugInfo.cpp:1153 @@ -1152,3 +1152,3 @@ unsigned Virtuality = 0; - unsigned VIndex = 0; + unsigned VIndex = -1u; ---------------- rsmith wrote: > Is this what debug info consumers expect for the non-virtual case? The debug info emitter doesn't use the virtual index of non-virtuals [1], but it's probably better to use zero for non-virtuals, as that cuts down on IR writer output. Done.
[1] http://llvm-cs.pcc.me.uk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp#1223 http://reviews.llvm.org/D18199 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
