rjmccall added a comment. Thanks for doing it this way, I think this is going to be much better long-term for LLVM.
================ Comment at: llvm/docs/LangRef.rst:2896 + * - ``bfloat`` + - 16-bit brain floating-point value (8-bit mantissa) + ---------------- scanon wrote: > bfloat and fp128 should agree w.r.t. whether or not the implicit bit counts. > Either 7 and 112 or 8 and 113. Also, we should use "significand" instead of > "mantissa". "Mantissa" has slipped in in a bunch of places, but "significand" > is the IEEE 754 terminology, and we should follow it. I agree with Steve. In general, there's no reason for these descriptions to be as terse as they are, especially for the non-standard formats. Someone reading IR and seeing `bfloat` for the first time is going to come here and not be any wiser unless they figure out the right web search. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
