dblaikie added a comment. > because it causes a 1% compile-time and memory usage regression.
Yeah, some memory regression is expected and, in my opinion, acceptable for the change. The compile time regression presumably came from the changes to the report_fatal_error handling in SmallVector - perhaps it could be changed/omitted in this commit, and done separately to assess the cost of changes to that error checking? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
