aykevl updated this revision to Diff 259621. aykevl added a comment. - moved test files out of the AVR-specific directory - removed the `REQUIRES:` line
In D78163#1984210 <https://reviews.llvm.org/D78163#1984210>, @rjmccall wrote: > I don't think the REQUIRES is needed unless there's something special about > AVR as a target. Clang doesn't conditionally compile out frontend target > support. I grepped for `REQUIRES:` and found just a few files with such a line - most files by far didn't specify any requirements. So it should be fine to leave it out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78163/new/ https://reviews.llvm.org/D78163 Files: clang/test/CodeGen/avr/target-cpu-defines/atmega328p.c clang/test/CodeGen/avr/target-cpu-defines/attiny104.c clang/test/CodeGen/avr/target-cpu-defines/common.c clang/test/Preprocessor/avr-atmega328p.c clang/test/Preprocessor/avr-attiny104.c clang/test/Preprocessor/avr-common.c Index: clang/test/Preprocessor/avr-common.c =================================================================== --- clang/test/Preprocessor/avr-common.c +++ clang/test/Preprocessor/avr-common.c @@ -1,4 +1,3 @@ -// REQUIRES: avr-registered-target // RUN: %clang_cc1 -E -dM -triple avr-unknown-unknown /dev/null | FileCheck -match-full-lines %s // CHECK: #define AVR 1 Index: clang/test/Preprocessor/avr-attiny104.c =================================================================== --- clang/test/Preprocessor/avr-attiny104.c +++ clang/test/Preprocessor/avr-attiny104.c @@ -1,4 +1,3 @@ -// REQUIRES: avr-registered-target // RUN: %clang_cc1 -E -dM -triple avr-unknown-unknown -target-cpu attiny104 /dev/null | FileCheck -match-full-lines %s // CHECK: #define AVR 1 Index: clang/test/Preprocessor/avr-atmega328p.c =================================================================== --- clang/test/Preprocessor/avr-atmega328p.c +++ clang/test/Preprocessor/avr-atmega328p.c @@ -1,4 +1,3 @@ -// REQUIRES: avr-registered-target // RUN: %clang_cc1 -E -dM -triple avr-unknown-unknown -target-cpu atmega328p /dev/null | FileCheck -match-full-lines %s // CHECK: #define AVR 1
Index: clang/test/Preprocessor/avr-common.c =================================================================== --- clang/test/Preprocessor/avr-common.c +++ clang/test/Preprocessor/avr-common.c @@ -1,4 +1,3 @@ -// REQUIRES: avr-registered-target // RUN: %clang_cc1 -E -dM -triple avr-unknown-unknown /dev/null | FileCheck -match-full-lines %s // CHECK: #define AVR 1 Index: clang/test/Preprocessor/avr-attiny104.c =================================================================== --- clang/test/Preprocessor/avr-attiny104.c +++ clang/test/Preprocessor/avr-attiny104.c @@ -1,4 +1,3 @@ -// REQUIRES: avr-registered-target // RUN: %clang_cc1 -E -dM -triple avr-unknown-unknown -target-cpu attiny104 /dev/null | FileCheck -match-full-lines %s // CHECK: #define AVR 1 Index: clang/test/Preprocessor/avr-atmega328p.c =================================================================== --- clang/test/Preprocessor/avr-atmega328p.c +++ clang/test/Preprocessor/avr-atmega328p.c @@ -1,4 +1,3 @@ -// REQUIRES: avr-registered-target // RUN: %clang_cc1 -E -dM -triple avr-unknown-unknown -target-cpu atmega328p /dev/null | FileCheck -match-full-lines %s // CHECK: #define AVR 1
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
