JonChesterfield added inline comments.
================
Comment at: clang/test/CodeGenCXX/builtin-amdgcn-fence-failure.cpp:5
+
+void test_amdgcn_fence_failure() {
+
----------------
arsenm wrote:
> Does this really depend on C++? Can it use OpenCL like the other builtin
> tests?This also belongs in a Sema* test directory since it's checking an error
Making it opencl-only would force some of the openmp runtime to be written in
opencl, which is not presently the case. Currently that library is written in a
dialect of hip, but there's a plan to implement it in openmp instead.
I'd much rather this builtin work from any language, instead of tying it to
opencl, as that means one can use it from openmp target regions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75917/new/
https://reviews.llvm.org/D75917
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
