tmsriram marked an inline comment as done. tmsriram added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:1975 +def fbasicblock_sections_EQ : Joined<["-"], "fbasicblock-sections=">, Group<f_Group>, Flags<[CC1Option, CC1AsOption]>, + HelpText<"Place each function's basic blocks in unique sections (ELF Only) : all | labels | none | <filename>">; def fdata_sections : Flag <["-"], "fdata-sections">, Group<f_Group>, ---------------- rsmith wrote: > It's not great to use the same argument as both one of three specific strings > and as an arbitrary filename. This not only prevents using those three names > as the file name, it also means adding any more specific strings is a > backwards-incompatible change. Can you find some way to tweak this to avoid > that problem? Understood, I have the following suggestions: 1) Would this be ugly? -fbasicblock-sections=list=<filename> 2) I could make this a completely new option. Is there a preference? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
