teemperor added a comment.
Beside Gabors comment I think I'm happy with this. Thanks!
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5939
+
+/// An ExternalASTSource that keeps track of the tags is completed.
+struct SourceWithCompletedTagList : clang::ExternalASTSource {
----------------
"is completed" -> "it completed"
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5954
+ SmallVectorImpl<Decl *> &Result) override {
+ DC->setHasExternalLexicalStorage(true);
+ }
----------------
You can remove this as you changed the check in the ASTImporter to only check
for the existence of an ExternalASTSource.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78000/new/
https://reviews.llvm.org/D78000
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
