grimar added a comment.
In D78024#1989287 <https://reviews.llvm.org/D78024#1989287>, @probinson wrote:
> I'm just reading this review for the first time, and my thought was, why is
> this interacting with implicit-check-not?
It was interacting (this patch was committed and fixed the issue), because the
code used the logic to add an EOF pattern
for "any trailing --implicit-check-not/CHECK-DAG/-NOTs" before the error about
"no check strings found with prefix" was reported.
I.e. this logic suppressed the error, because `CheckStrings` was not empty
anymore:
if (CheckStrings->empty()) {
errs() << "error: no check strings found with prefix"
...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78024/new/
https://reviews.llvm.org/D78024
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
