hubert.reinterpretcast added inline comments.
================ Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1509 + + MCSymbol *Name = getSymbol(&F); + if (TM.getTargetTriple().isOSBinFormatXCOFF() && !F.isIntrinsic()) { ---------------- Add a comment that this gives us the function descriptor symbol. ================ Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2146 } } ---------------- Replicate the ``` llvm_unreachable("Unknown linkage type!"); ``` here before falling off the end of a function that does not return `void`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits