MaskRay accepted this revision.
MaskRay added a comment.

LGTM.

But hope @ruiu or @int3 can clarify that we can't get rid of the `__APPLE__` 
special case in:

  // lld/tools/lld/lld.cpp
  static Flavor parseProgname(StringRef progname) {
  #if __APPLE__
    // Use Darwin driver for "ld" on Darwin.
    if (progname == "ld")
      return Darwin;
  #endif
  
  #if LLVM_ON_UNIX
    // Use GNU driver for "ld" on other Unix-like system.
    if (progname == "ld")
      return Gnu;
  #endif


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76452/new/

https://reviews.llvm.org/D76452



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to