rjmccall added a comment. In D76384#1984498 <https://reviews.llvm.org/D76384#1984498>, @mibintc wrote:
> Responding to @rjmccall 's review. John, after this is approved I want to > proceed with pragma float_control as proposed in D72841 > <https://reviews.llvm.org/D72841>. Can you recommend an approach, do you > think I will need to do it incrementally? I think the basic technical approach from that patch seems reasonable. It's not my goal to hold up your work to pursue other technical goals; we took this detour just to minimize the memory impact of your work. I *would* like an NFC patch first that renames `FPFeatures` to something like `CurFPFeatures` in order to more clearly distinguish it from `FPOptions` in Sema code, though. That should be very quick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
