SjoerdMeijer added inline comments.
================ Comment at: clang/docs/MatrixTypes.rst:12 +fixed-size matrices as language values and perform arithmetic on them. + +This feature is currently experimental, and both its design and its ---------------- Would it be good to set expectations here or in the section below: define that we're talking about 2-dimensional m × n matrices? ================ Comment at: clang/docs/MatrixTypes.rst:25 +element type, rows, and columns are the same type. A value of a matrix type +includes storage for ``rows * columns`` values of the *element ype*. The +internal layout, overall size and alignment are implementation-defined. ---------------- typo: ype -> type ================ Comment at: clang/docs/MatrixTypes.rst:27 +internal layout, overall size and alignment are implementation-defined. +A *matrix element type* must be a real type (as in C99 6.2.5p17) excluding +enumeration types or an implementation-defined half-precision floating point ---------------- above you're using *element type* and here *matrix element type*. Since hopefully we're talking about the same things, "matrix *element type*" would be more consistent. But this is just a nit, my main question is about the types: why not e.g. define this to be the C11 types, that include _FloatN types, so that we can include N=16? Or is this intentionally omitted? I haven't even checked if this is supported in the architecture extension, but might make sense? And also, an element type cannot be an integer type? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
