yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
================
Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn.cl:541
switch (d) {
- case 0: *out = __builtin_amdgcn_workgroup_size_x(); break;
+ case 0: *out = __builtin_amdgcn_workgroup_size_x() + 1; break;
case 1: *out = __builtin_amdgcn_workgroup_size_y(); break;
----------------
JonChesterfield wrote:
> This looks unrelated to the return type change
Without that change, the builtin return type is wrong and clang does not insert
conversion for this "add" operation and causes assertion. Therefore this small
change makes sure that error will not happen again.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77390/new/
https://reviews.llvm.org/D77390
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
