hoyFB accepted this revision.
hoyFB added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:456
+  TargetLibraryAnalysis(const Triple &T)
+      : BaselineInfoImpl(TargetLibraryInfoImpl(T)) {}
+  TargetLibraryAnalysis(const TargetLibraryInfoImpl &BaselineInfoImpl)
----------------
hoyFB wrote:
> Can `T` just be used here? `TargetLibraryInfoImpl` comes with a such 
> constructor: `TargetLibraryInfoImpl(const Triple &T)`
Unlikely not. That is an explicit constructor and `BaselineInfoImpl` is an 
`Optional` object.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77952/new/

https://reviews.llvm.org/D77952



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to