efriedma marked an inline comment as done.
efriedma added inline comments.
================
Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:60
+ } else {
emitError(loc) << "expected sequential LLVM types wrapping a scalar";
return nullptr;
----------------
ftynse wrote:
> Nit: can we update the error message not to mention "sequential LLVM type"
> anymore if sequential type is no longer a thing?
Other MLIR code in this file still refers to them as sequential types, but I
guess it might make sense to change in this context.
Is it realistically possible to hit this path? I'm not sure how to write a
testcase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75661/new/
https://reviews.llvm.org/D75661
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
