MyDeveloperDay added inline comments.
================
Comment at: clang/lib/Format/Format.cpp:2700
+ if (std::error_code EC = Text.getError())
+ return make_string_error(EC.message());
+ std::error_code ParserErrorCode =
----------------
if you return here IsSuitable will be true..
================
Comment at: clang/lib/Format/Format.cpp:2707
+ } else if (ParserErrorCode != ParseError::Success) {
+ return make_string_error("Error reading " + ConfigFile + ": " +
+ ParserErrorCode.message());
----------------
again here you need to set IsSutable to false
================
Comment at: clang/lib/Format/Format.cpp:2709
+ ParserErrorCode.message());
+ }
+ return Style;
----------------
maybe its better just to set this to true here *IsSuitable = true; and set it
to false on line @2695
================
Comment at: clang/lib/Format/Format.cpp:2792
+ } else {
+ return *ConfigStyle;
}
----------------
this could then mean you return with something wrong here..
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72326/new/
https://reviews.llvm.org/D72326
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
