Szelethus added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:112
reportPiece(NoteID, Piece->getLocation().asLocation(),
- Piece->getString(), Piece->getRanges(),
Piece->getFixits());
+ Piece->getString().str(), Piece->getRanges(),
+ Piece->getFixits());
----------------
Szelethus wrote:
> NoQ wrote:
> > Szelethus wrote:
> > > martong wrote:
> > > > Why the `.str()` ?
> > > `StringRef` no longer converts to `std::string` implicitly.
> > But it seems to have been fine before(?)
> Mind that I changed the parameter of `reportPiece` to `std::string` from
> `StringRef`.
Couldn't see the forest behind the trees :^)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76605/new/
https://reviews.llvm.org/D76605
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
