jdoerfert marked an inline comment as done. jdoerfert added inline comments.
================ Comment at: clang/lib/Sema/SemaExprCXX.cpp:8260 } - return Result; + + if (!SemaRef.getLangOpts().OpenMP || !Result.isUsable() || ---------------- mikerice wrote: > I was expecting the code would be added to RebuildCallExpr in > TreeTransform.h. This seems to just override one of the classes derived from > TreeTransform. > > I think I'd try adding it to TreeTransform then check all the cases where a > subclass overrides RebuildCallExpr and try to determine if something needs to > be done there. I'm not paying attention -.- This is the one class that overrides `RebuildCallExpr` in clang and obviously not the right place for this. I will put it in `TreeTransform::RebuildCallExpr` which is in `clang/lib/Sema/TreeTransform.h` now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77290/new/ https://reviews.llvm.org/D77290 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits