vsavchenko marked an inline comment as done. vsavchenko added a comment. In D77551#1964441 <https://reviews.llvm.org/D77551#1964441>, @NoQ wrote:
> Looks great, thanks! Do you already have commit access or should i commit > this for you? Thanks :-) No, I don't have commit access ================ Comment at: clang/test/Analysis/SpecialFunctionsCFError.cpp:2 +// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.coreFoundation.CFError \ +// RUN: -analyzer-store=region -verify %s + ---------------- Szelethus wrote: > NoQ wrote: > > `-analyzer-store=region` is redundant; it's the default and the only > > possible value for this option. We should remove it from other tests as > > well. > The default lit command is a bit silly. What does `-setup-analyzer` or > something like that even do? Should I remove it from here in this commit or we should clean up all tests at once? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77551/new/ https://reviews.llvm.org/D77551 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
