yaxunl marked 2 inline comments as done. yaxunl added inline comments.
================ Comment at: clang/lib/Sema/Sema.cpp:1558 + // visited before. + if (Done.count(FD)) + return; ---------------- rjmccall wrote: > `insert` returns whether it changed the set, so you can combine this check > with the insertion unless the exact ordering is important. The order is important here. We cannot inert until the body of the function has been traversed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77028/new/ https://reviews.llvm.org/D77028 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
