martong marked 2 inline comments as done.
martong added a comment.
In D77410#1963288 <https://reviews.llvm.org/D77410#1963288>, @Szelethus wrote:
> LGTM! Maybe its worth glancing over the rest of the code (comments in
> particular) whether anything would be outdated by this change.
Yeah, seems like the comments are still aligned. Also, I am going to submit the
next patch, which will scramble the current structures (and probably the
related comments as well).
================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:553
+ QualType ActualT = FD->getParamDecl(I)->getType().getCanonicalType();
assert(ActualT.isCanonical());
if (ActualT != FormalT)
----------------
balazske wrote:
> This assert can be removed, after the previous `getCanonicalType` call it
> looks redundant.
Thanks, good catch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77410/new/
https://reviews.llvm.org/D77410
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
