EricWF added a comment.

So this LGTM except for one last change (I'm sorry). LIT now knows when 
"-Werror=thread-safety" is being passed. Could you change the tests guarded by 
"#if !defined(__clang__) || !__has_attribute(aquire_capability)` to say "// 
REQUIRES: thread-safety" instead? I prefer using LIT to manage when tests run 
because it can report un-run tests where simply using macros cant.

After that LGTM.


http://reviews.llvm.org/D14731



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to