jdoerfert abandoned this revision. jdoerfert added a comment. In D77239#1955720 <https://reviews.llvm.org/D77239#1955720>, @tra wrote:
> > The other macro uses a unqualified lookup already and the qualified one > > will cause problems in the OpenMP overlay. > > There's a bit of inconsitency here. While > `__CUDA_CLANG_FN_INTEGER_OVERLOAD_2` indeed uses unqualified lookup, pretty > much all other functions use qualified global scope lookups, which, I believe > is correct, as we want to use the functions defined by CUDA headers there. > > @jlebar -- WDYT? It turns out I can disable this entire code region for OpenMP (or have to for c++17 I tihnk), so I'll abandon this revision and you make it consistent in the way that fits your need :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77239/new/ https://reviews.llvm.org/D77239 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits