jcai19 marked 4 inline comments as done.
jcai19 added inline comments.
================
Comment at: clang/lib/CodeGen/CGDecl.cpp:1814
+ if (StopAfter) {
+ static unsigned Counter = 0;
+ if (Counter >= StopAfter)
----------------
rjmccall wrote:
> srhines wrote:
> > MaskRay wrote:
> > > I am a bit worried about the static variable. This makes CodeGen not
> > > reusable.
> > The counter could exist in ASTContext instead.
> IRGenModule would be the more appropriate place.
I can't seem to find IRGenModule. Do you mean CodeGenModule by any chance?
Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77168/new/
https://reviews.llvm.org/D77168
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
