kpn marked 3 inline comments as done. kpn added a comment. Note that the AArch64 backend isn't ready for some of these changes. That's why the test is marked XFAIL.
================ Comment at: clang/lib/CodeGen/CGBuiltin.cpp:5706 + Function *F; + //exit(2); // XXX + if (Builder.getIsFPConstrained()) ---------------- These exit() calls tie back into my test matrix. They'll be removed when I eventually push. ================ Comment at: clang/test/CodeGen/aarch64-neon-intrinsics-constrained.c:288 + +// XXX FIXME do we need to check for both w and x registers? +// COMMON-LABEL: test_vceq_f64 ---------------- Anyone? I'm not an ARM expert. ================ Comment at: clang/test/CodeGen/aarch64-neon-intrinsics-constrained.c:889 + +// FIXME why the unused bitcast? There are several of them! +// COMMON-LABEL: test_vrnda_f64 ---------------- ??? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77074/new/ https://reviews.llvm.org/D77074 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits