martong added a comment.
Wohoow! I am impressed, this is really nice work, I like it! :) Could not find
any glitch, looks good from my side once you address NoQ's concerns.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:125
+ Msg = std::string(llvm::formatv(
+ "Possibly not enough {0} bytes for array allocation which "
+ "requires "
----------------
Maybe the below could be a wording that's more easy to follow?
`{0} bytes is possibly not enough for array allocation which ...`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76996/new/
https://reviews.llvm.org/D76996
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
