Hahnfeld added inline comments.
================
Comment at: clang/CMakeLists.txt:311
+ "SystemZ Default Arch")
+add_definitions( -DCLANG_SYSTEMZ_DEFAULT_ARCH="${CLANG_SYSTEMZ_DEFAULT_ARCH}")
+
----------------
Passing values like this is unusual for CMake and causes all source files to be
recompiled if the value is changed. Instead could we add this to
`include/clang/Config/config.h.cmake` like other `CLANG_DEFAULT_*` options?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75914/new/
https://reviews.llvm.org/D75914
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
