tra added a comment. In D76365#1946938 <https://reviews.llvm.org/D76365#1946938>, @hliao wrote:
> The new revision is accepted, right? Just want to confirm as it seems you > accept it before I posted the new change. The approval was for the old version. I didn't undo it when I reopened the review. The diff looks OK, though the last variant still leaves open the question of what's the meaning of these attributes and what are the restrictions on their use. So what's the reasonable thing to do if I write something like this: __attribute__((device_builtin_surface_type)) int foo; // Ignore? Warn? Error? Do something sensible? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D76365 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
