stuij added inline comments.
================
Comment at: clang/test/Driver/aarch64-cpus.c:622
+
+// The BFloat16 extension is a mandatory component of the Armv8.6-A
extensions, but is permitted as an
+// optional feature for any implementation of Armv8.2-A to Armv8.5-A
(inclusive)
----------------
SjoerdMeijer wrote:
> Do we need 2 additional tests here?
> - one for v8.6,
> - and another with SVE?
>
>
I think we're ok here.
- for v8.6 the driver doesn't pass bfloat as an argument
- SVE: from a cmdline perspective, there's no special interaction between
bfloat and SVE. either can be active without the other.
================
Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:7867
+ V128, asm, ".4s",
+ []> {
+ let AsmString = !strconcat(asm, "{\t$Rd", ".4s", ", $Rn", ".8h",
----------------
SjoerdMeijer wrote:
> and perhaps this one. But looks intentional, perhaps it's fine then, I don't
> know.
Yes, the square brackets will be filled in in a next patch. I'll just leave
them as is.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76062/new/
https://reviews.llvm.org/D76062
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
