tetsuo-cpp added a comment. In D75901#1920397 <https://reviews.llvm.org/D75901#1920397>, @njames93 wrote:
> In D75901#1916119 <https://reviews.llvm.org/D75901#1916119>, @tetsuo-cpp > wrote: > > > @njames93 @MaskRay > > Thanks for helping me with testing. I'll remember this for next time. > > > > I also saw this pattern of retrieving `LangOptions` from an `ASTContext` in > > some other checks (`RedundantExpressionCheck` and `StaticAssertCheck`) but > > I didn't change them to use `getLangOpts` since the `ASTContext` is used > > for other stuff. > > > Its also not a good idea to change unrelated code in a review Understood. Thanks @njames93. Could you please help me commit this change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75901/new/ https://reviews.llvm.org/D75901 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
