sfertile added inline comments.
================
Comment at: clang/lib/Basic/Targets/PPC.h:373
+ // This is the ELF definition, and is overridden by the Darwin and AIX
+ // sub-target.
return TargetInfo::PowerABIBuiltinVaList;
----------------
Minor nit: `target` --> `targets`.
================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175
namespace {
/// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information.
class PPC32_SVR4_ABIInfo : public DefaultABIInfo {
----------------
This name and comment is misleading, the class is used for both SVR4 and
Darwin, and after this patch AIX. We need to fix the name comment to reflect
that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76360/new/
https://reviews.llvm.org/D76360
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
