[PATCH] D76289: [NFC][Attr TableGen] Emit Spelling Enum for Attr types if there >1

[Erich Keane via Phabricator via cfe-commits]

erichkeane updated this revision to Diff 250818.
erichkeane marked 2 inline comments as done.
erichkeane added a comment.

Did as @rnk suggested, and it fixed all the problems.  Just changed the logic 
for emitting the enum.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76289/new/

https://reviews.llvm.org/D76289

Files:
  clang/utils/TableGen/ClangAttrEmitter.cpp


Index: clang/utils/TableGen/ClangAttrEmitter.cpp
===================================================================
--- clang/utils/TableGen/ClangAttrEmitter.cpp
+++ clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -2329,7 +2329,7 @@
     SemanticSpellingMap SemanticToSyntacticMap;
 
     std::string SpellingEnum;
-    if (!ElideSpelling)
+    if (Spellings.size() > 1)
       SpellingEnum = CreateSemanticSpellings(Spellings, 
SemanticToSyntacticMap);
     if (Header)
       OS << SpellingEnum;



Index: clang/utils/TableGen/ClangAttrEmitter.cpp
===================================================================
--- clang/utils/TableGen/ClangAttrEmitter.cpp
+++ clang/utils/TableGen/ClangAttrEmitter.cpp
@@ -2329,7 +2329,7 @@
     SemanticSpellingMap SemanticToSyntacticMap;
 
     std::string SpellingEnum;
-    if (!ElideSpelling)
+    if (Spellings.size() > 1)
       SpellingEnum = CreateSemanticSpellings(Spellings, SemanticToSyntacticMap);
     if (Header)
       OS << SpellingEnum;

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits