NoQ added inline comments.
================ Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:217 + mgr.template registerChecker<T>(); } ---------------- Szelethus wrote: > baloghadamsoftware wrote: > > Why do we need `MGR` here as template parameter? Is this function also used > > for other class instances than `CheckerManager`? I fail to see such > > invocation. > Include cycles :) `CheckerManager.h` includes `CheckerRegistry.h`, so we can > only forward declare `CheckerManager`, hence the need for a template > parameter. Maybe put the implementation into the cpp file instead? ================ Comment at: clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:33 #include "llvm/Support/ErrorHandling.h" +#include <memory> using namespace clang; ---------------- Why? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
