NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I like this! Please address the remaining nits^^
================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:102
+ /// Given a range, should the argument stay inside or outside this range?
+ enum RangeKind { OutOfRange, WithinRange };
----------------
baloghadamsoftware wrote:
> I would move this into the class to encapsulate the values instead of
> contaminating namespace `ento`.
It's checker-local anyway and i suspect we write these a lot in the summaries,
so let's keep it in the global scope.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74973/new/
https://reviews.llvm.org/D74973
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
