NoQ added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:511 + // + // Also, we cannot model the parameters. CXXInheritedCtorInitExpr doesn't + // take arguments and doesn't model parameter initialization because there is ---------------- martong wrote: > NoQ wrote: > > I'd rather put this Richard's comment somewhere near the respective > > `CallEvent` definition. We clearly don't need to analyze these functions, > > so it doesn't really matter for anybody who reads this code that there are > > temporary technical difficulties with analyzing them. On the other hand, it > > does matter a lot for people who try to understand how to implement the > > call event correctly. > Ok, I moved this part of the comment into CallEvent.h . Perfect, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits