aaron.ballman added a reviewer: rsmith.
aaron.ballman added a subscriber: rsmith.
aaron.ballman added a comment.
I think this is a reasonable approach (including moving
`ParsedAttributesWithRange` into `Sema`), but we should have test coverage for
the places where we're now using a range where we weren't previously (to ensure
we're okay with the positional changes we're introducing).
Adding @rsmith to ensure I've not misunderstood layering concerns.
================
Comment at: clang/test/SemaCXX/switch-implicit-fallthrough.cpp:110-114
+ case 26:
+ return 0;
+ __attribute__((fallthrough)); // expected-warning{{fallthrough annotation
in unreachable code}}
+ case 27:
+ break;
----------------
This test seems unrelated to the patch, or am I misunderstanding something?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75844/new/
https://reviews.llvm.org/D75844
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
