Anastasia added inline comments. ================ Comment at: include/clang/AST/OpenCLImageTypes.def:39 @@ +38,3 @@ + +IMAGE_READ_TYPE(image1d, OCLImage1d) +IMAGE_READ_TYPE(image1d_array, OCLImage1dArray) ---------------- bader wrote: > Minor comment: any image access qualifier can be applied to any image type, > so I think it's better to list all image types once to avoid duplication. > Sure, we could try that. Although, I think there are places where this file is included needing images without an access qualifier using GENERIC_IMAGE_TYPE macro.
For example in include/clang/Basic/TokenKinds.def http://reviews.llvm.org/D17821 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
