efriedma added inline comments.
================ Comment at: clang/utils/TableGen/SveEmitter.cpp:86 + OS << "#ifndef __cplusplus\n"; + OS << "#include <stdbool.h>\n"; + OS << "#endif\n\n"; ---------------- I'd prefer to avoid depending on stdbool if it isn't necessary. ================ Comment at: clang/utils/TableGen/SveEmitter.cpp:92 + OS << "typedef double float64_t;\n"; + OS << "typedef bool bool_t;\n\n"; + ---------------- The ACLE documentation doesn't say anything about float16_t etc.? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75298/new/ https://reviews.llvm.org/D75298 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
