Szelethus requested changes to this revision.
Szelethus added a comment.
This revision now requires changes to proceed.

We should totally dedicate an error kind of `fseek`, see (and please respond, 
if you could to) D75356#inline-689287 
<https://reviews.llvm.org/D75356#inline-689287>.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:382-384
+  C.addTransition(StateNotFailed);
+  C.addTransition(StateFailedWithFError);
+  C.addTransition(StateFailedWithoutFError);
----------------
This seems a bit excessive, we could merge the last two into `FSeekError`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75851/new/

https://reviews.llvm.org/D75851



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to